search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.26k stars 299 forks source link

Added Makefile to simplify build and test process; Ensure proper go fmt is maintained #144

Closed filipecosta90 closed 3 years ago

filipecosta90 commented 3 years ago

The following PR adds a Makefile which simplifies the test and build process of binaries. You can build:

It also simplifies testing. To run all tests:

make test

Apart from it, it also ensure that the proper go fmt is maintained ( via make checkfmt rule ). You can go fmt via make fmt

codecov-io commented 3 years ago

Codecov Report

Merging #144 (eeb35c6) into master (123f6aa) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   65.40%   65.45%   +0.04%     
==========================================
  Files         145      145              
  Lines        5952     5948       -4     
==========================================
  Hits         3893     3893              
+ Misses       1946     1942       -4     
  Partials      113      113
Impacted Files Coverage Δ
load/loader.go 51.20% <0.00%> (ø)
pkg/query/stat_processor.go 10.71% <0.00%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 123f6aa...0ab1fa9. Read the comment docs.

filipecosta90 commented 3 years ago

Two minor issues then we can merge

I believe all issues addressed. WDYT?

codecov-commenter commented 3 years ago

Codecov Report

Merging #144 (08e0da9) into master (123f6aa) will decrease coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   65.40%   65.25%   -0.16%     
==========================================
  Files         145      145              
  Lines        5952     5966      +14     
==========================================
  Hits         3893     3893              
- Misses       1946     1960      +14     
  Partials      113      113
Impacted Files Coverage Δ
pkg/query/stats.go 100.00% <ø> (ø)
pkg/targets/timescaledb/file_data_source.go 77.27% <ø> (ø)
pkg/targets/timescaledb/creator.go 42.64% <0.00%> (-1.63%) :arrow_down:
pkg/targets/timescaledb/process.go 21.85% <0.00%> (-1.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 123f6aa...08e0da9. Read the comment docs.

RobAtticus commented 3 years ago

Looks good, I'll merge