Closed filipecosta90 closed 3 years ago
Merging #147 (3006d29) into master (123f6aa) will decrease coverage by
0.26%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 65.40% 65.14% -0.27%
==========================================
Files 145 145
Lines 5952 5976 +24
==========================================
Hits 3893 3893
- Misses 1946 1970 +24
Partials 113 113
Impacted Files | Coverage Δ | |
---|---|---|
load/loader.go | 42.95% <0.00%> (-8.25%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 123f6aa...3006d29. Read the comment docs.
Merging #147 (e1b0c7c) into master (a045665) will decrease coverage by
0.87%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 65.25% 64.37% -0.88%
==========================================
Files 145 145
Lines 5966 6047 +81
==========================================
Hits 3893 3893
- Misses 1960 2040 +80
- Partials 113 114 +1
Impacted Files | Coverage Δ | |
---|---|---|
load/loader.go | 42.95% <0.00%> (-8.25%) |
:arrow_down: |
pkg/query/benchmarker.go | 61.00% <0.00%> (-12.50%) |
:arrow_down: |
pkg/query/stat_processor.go | 7.03% <0.00%> (-3.20%) |
:arrow_down: |
pkg/query/stats.go | 100.00% <0.00%> (ø) |
|
pkg/targets/timescaledb/file_data_source.go | 77.27% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a045665...e1b0c7c. Read the comment docs.
@jonatas @antekresic I believe all comments are addressed on the latest commit. Can you guys check it?
This PR kicks off the discussion about persisting ingestion/querying benchmark result stats in a common format. We've added the samples to full_cycle_minitest.
To do so, we've added
--results-file
to both loader and query runner tools. If no--result-file
is specified then no summary result JSON is stored. Bellow you can find the sample output jsons for both loading and querying after runningPASSWORD="password" ./scripts/full_cycle_minitest/full_cycle_minitest_timescaledb.sh
with TimeScaleDB locally available on default ports.Ingestion result sample json output
query result sample json output