search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.26k stars 299 forks source link

Merging original multi-node branch to allow new SIMULATOR mode #152

Closed ryanbooz closed 3 years ago

ryanbooz commented 3 years ago

In working to ingest and benchmark a large dataset (~200 billion metrics), I merged the original multi-node branch into some recent changes change off of master which allowed running the SIMULATOR into a multi-node setup. The goal would be to then merge this branch from @blagojts into master.

I think there should be some discussion about the parameter flag names, or at least how they act together for single vs. multi-node. It's not just a one parameter switch... so we need to just be more clear.

Caveat - I'm not a Golang dev. I understand the basics enough to get the changes into the right place, but I'm sure we need to discuss more tests (😱). I mostly just didn't want this to be on my laptop only.

niksajakovljevic commented 3 years ago

Hey @ryanbooz, thanks for the PR! However we need to rebase these changes and top of current master. Since CI tests are failing maybe rebasing will solve that problem as well. Try running go test -v -race locally to make sure that tests are passing.

atanasovskib commented 3 years ago

Fixed the failing test and merged locally in the target branch. Closing