search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.29k stars 300 forks source link

Refactor serialize pkg: improved Point API, fewer pools #17

Closed RobAtticus closed 6 years ago

RobAtticus commented 6 years ago

The use of several pools were holdovers from the original code but after some benchmarking they don't appear to speed things up and require extra code to sanitize the reused buffers. Aside from the flatbuffer pool, all pools have been removed and use of standard make instead.

The Point API was updated to check the values of fields and tags to allow for more comprehensive testing in other packages, such as devops. As way of example, updated tests for generating a Redis data point has been added.

codecov-io commented 6 years ago

Codecov Report

Merging #17 into master will increase coverage by 3.73%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   44.48%   48.22%   +3.73%     
==========================================
  Files          61       60       -1     
  Lines        2558     2561       +3     
==========================================
+ Hits         1138     1235      +97     
+ Misses       1403     1313      -90     
+ Partials       17       13       -4
Impacted Files Coverage Δ
cmd/tsbs_generate_data/serialize/mongo.go 100% <100%> (+9.52%) :arrow_up:
cmd/tsbs_generate_data/serialize/influx.go 100% <100%> (ø) :arrow_up:
cmd/tsbs_generate_data/serialize/point.go 100% <100%> (+90.62%) :arrow_up:
cmd/tsbs_generate_data/serialize/timescaledb.go 100% <0%> (+9.09%) :arrow_up:
cmd/tsbs_generate_data/serialize/cassandra.go 100% <0%> (+9.3%) :arrow_up:
cmd/tsbs_generate_data/devops/redis.go 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0fd660...31f9889. Read the comment docs.