timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data

MIT License

1.29k stars 300 forks source link

tsbs_load_timescaledb/creator.go: handle case-sensitive columns #46

Closed lilvinz closed 5 years ago

lilvinz commented 5 years ago

closes #45

lilvinz commented 5 years ago

Tests still have to be fixed.

codecov-io commented 5 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is 37.5%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files          66       66           
  Lines        3172     3172           
=======================================
  Hits         1703     1703           
  Misses       1457     1457           
  Partials       12       12

Impacted Files	Coverage Δ
cmd/tsbs_load_timescaledb/creator.go	`37.75% <37.5%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 431ce18...0f79e9d. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is 37.5%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files          66       66           
  Lines        3172     3172           
=======================================
  Hits         1703     1703           
  Misses       1457     1457           
  Partials       12       12

Impacted Files	Coverage Δ
cmd/tsbs_load_timescaledb/creator.go	`37.75% <37.5%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 431ce18...0f79e9d. Read the comment docs.

RobAtticus commented 5 years ago

I'm inclined to say that it is preferable that the schemas for any other use cases adopt the convention of using all lowercase names rather than add the extra quoting that is unnecessary in the current use cases.

RobAtticus commented 5 years ago

Closing this pending further objection.