timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.29k stars 300 forks source link

Add support to generate queries for PG #49

Closed sdressler closed 5 years ago

sdressler commented 5 years ago

This is an implementation for #35. One can simply use postgresql as format. Running the queries can be done with the default tool.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.13%. The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   53.72%   53.59%   -0.14%     
==========================================
  Files          66       66              
  Lines        3179     3187       +8     
==========================================
  Hits         1708     1708              
- Misses       1459     1467       +8     
  Partials       12       12
Impacted Files Coverage Δ
...s_generate_queries/databases/timescaledb/devops.go 15.49% <7.69%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c970c76...e6d4daa. Read the comment docs.

RobAtticus commented 5 years ago

@sdressler just wanted to clarify I am good with removing the postgresql format and just adding a use-time-bucket flag, in case you were blocking on that.

sdressler commented 5 years ago

No worries, I am blocked by time constraints atm.

Am 25.01.2019 um 17:06 schrieb RobAtticus notifications@github.com:

@sdressler just wanted to clarify I am good with removing the postgresql format and just adding a use-time-bucket flag, in case you were blocking on that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

RobAtticus commented 5 years ago

Cool, no problem. Just wanted to make sure I wasn't the blocker.

sdressler commented 5 years ago

That is very kind of you :-)

Am 25.01.2019 um 17:50 schrieb RobAtticus notifications@github.com:

Cool, no problem. Just wanted to make sure I wasn't the blocker.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sdressler commented 5 years ago

Finally found the time and updated as discussed.

sdressler commented 5 years ago

Done. Go ahead, sir.

RobAtticus commented 5 years ago

Thanks again, really appreciate it!