timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data

MIT License

1.29k stars 300 forks source link

Fix broken query output and minor other nits #58

Closed RobAtticus closed 5 years ago

RobAtticus commented 5 years ago

The single-group-by queries SQL for TimescaleDB was missing a comma after the time grouping, creating an incorrect SQL statement. In addition, a sanity check is added to make sure there are other select clauses besides just the time grouping.

This also includes minor nits including:

fixing the alphabetical order in the README
have the generate_queries script output a symlink per query
add support for the -timescaledb-use-time-bucket flag to scripts

codecov-io commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.02%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   52.06%   52.03%   -0.03%     
==========================================
  Files          73       73              
  Lines        3519     3521       +2     
==========================================
  Hits         1832     1832              
- Misses       1674     1676       +2     
  Partials       13       13

Impacted Files	Coverage Δ
...s_generate_queries/databases/timescaledb/devops.go	`15.27% <0%> (-0.22%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b195e...ea67635. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.02%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   52.06%   52.03%   -0.03%     
==========================================
  Files          73       73              
  Lines        3519     3521       +2     
==========================================
  Hits         1832     1832              
- Misses       1674     1676       +2     
  Partials       13       13

Impacted Files	Coverage Δ
...s_generate_queries/databases/timescaledb/devops.go	`15.27% <0%> (-0.22%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b195e...ea67635. Read the comment docs.