Closed niksajakovljevic closed 5 years ago
Merging #63 into master will decrease coverage by
0.7%
. The diff coverage is5.37%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 52.29% 51.58% -0.71%
==========================================
Files 73 73
Lines 3536 3586 +50
==========================================
+ Hits 1849 1850 +1
- Misses 1673 1720 +47
- Partials 14 16 +2
Impacted Files | Coverage Δ | |
---|---|---|
cmd/tsbs_load_timescaledb/main.go | 49.27% <14.28%> (-3.96%) |
:arrow_down: |
cmd/tsbs_load_timescaledb/creator.go | 27.33% <2.22%> (-6%) |
:arrow_down: |
cmd/tsbs_load_timescaledb/process.go | 23.29% <7.31%> (-2.52%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d360ad1...9368775. Read the comment docs.
@RobAtticus I'll update the commit message with my findings. In my benchmarks I've got around 5-10% increase in write throughput and about 35% improvement for queries when using binary format.
Using binary format when talking to TimescaleDB means less data being sent back and forth. Config option is added to force TEXT format if needed (binary is default). PGX driver is used for binary and PQ driver for TEXT.