search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.29k stars 300 forks source link

Add CrateDB database support to the time series benchmark suite. #71

Closed kovrus closed 5 years ago

kovrus commented 5 years ago

The PR adds the CrateDB database support to the time series benchmark suit. CrateDB supports the PostgreSQL wire protocol v3 so we use the pgx PostgreSQL driver to connect to the database.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #71 into master will decrease coverage by 1.06%. The diff coverage is 57.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   66.03%   64.96%   -1.07%     
==========================================
  Files          77       84       +7     
  Lines        3819     4282     +463     
==========================================
+ Hits         2522     2782     +260     
- Misses       1266     1463     +197     
- Partials       31       37       +6
Impacted Files Coverage Δ
internal/inputs/utils.go 78.26% <ø> (ø) :arrow_up:
cmd/tsbs_load_cratedb/processor.go 0% <0%> (ø)
cmd/tsbs_load_cratedb/main.go 0% <0%> (ø)
internal/inputs/generator_queries.go 91.4% <100%> (+0.13%) :arrow_up:
internal/utils/time_interval.go 96.15% <100%> (+0.32%) :arrow_up:
cmd/tsbs_generate_data/serialize/cratedb.go 100% <100%> (ø)
internal/inputs/generator_data.go 89.92% <100%> (+0.37%) :arrow_up:
cmd/tsbs_load_cratedb/creator.go 21% <21%> (ø)
cmd/tsbs_load_cratedb/scan.go 82.97% <82.97%> (ø)
query/cratedb.go 88.88% <88.88%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad198f4...1039b34. Read the comment docs.

RobAtticus commented 5 years ago

Hi, thanks for doing this! We'll take a look and should have a review shortly. Apologies for the delay

kovrus commented 5 years ago

@RobAtticus please take a look at the last fixup commits. I've done necessary changes and rebased the branch with master.

kovrus commented 5 years ago

Hi @RobAtticus, is there anything from my side that is blocking this PR from being merged?

RobAtticus commented 5 years ago

Sorry @kovrus , we've been having an off-site this week so things have been a bit slow on our end preparing for it and this week. I'll hopefully have more time to look at it next week. As long as it's up to date rebased on master, it should be good from your end and I'll check ASAP.

kovrus commented 5 years ago

@RobAtticus thanks for your time and the review! 👍 I've addressed you comments.

RobAtticus commented 5 years ago

Thanks for submitting this btw, looks great and we're happy to add CrateDB!

RobAtticus commented 5 years ago

Merged in, thanks again for contributing this!

kovrus commented 5 years ago

@RobAtticus Thanks for the review!