Closed antekresic closed 5 years ago
Merging #72 into master will increase coverage by
3.19%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 53.93% 57.13% +3.19%
==========================================
Files 76 76
Lines 3719 3719
==========================================
+ Hits 2006 2125 +119
+ Misses 1690 1570 -120
- Partials 23 24 +1
Impacted Files | Coverage Δ | |
---|---|---|
cmd/tsbs_generate_queries/uses/devops/common.go | 96.82% <0%> (+9.52%) |
:arrow_up: |
...s_generate_queries/databases/timescaledb/devops.go | 98.61% <0%> (+78.47%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 19932e7...c8d8859. Read the comment docs.
Merging #72 into master will increase coverage by
3.19%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 53.93% 57.13% +3.19%
==========================================
Files 76 76
Lines 3719 3719
==========================================
+ Hits 2006 2125 +119
+ Misses 1690 1570 -120
- Partials 23 24 +1
Impacted Files | Coverage Δ | |
---|---|---|
cmd/tsbs_generate_queries/uses/devops/common.go | 96.82% <0%> (+9.52%) |
:arrow_up: |
...s_generate_queries/databases/timescaledb/devops.go | 98.61% <0%> (+78.47%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 19932e7...fc4ba15. Read the comment docs.
Thanks for the feedback @blagojts and @RobAtticus .
I incorporated your suggestions and force pushed the commit with matching extended description.
Let me know if there is anything else blocking us from merging this.
@RobAtticus fixed all the durations. Should be good to go now.
Making a small PR for unit tests to give people a chance to review and comment on testing style.
Once this one gets approved and merged, expect a bigger PR covering more code using the same style.