search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.29k stars 300 forks source link

Add unit tests to query generation functions for various databases #76

Closed antekresic closed 5 years ago

antekresic commented 5 years ago

Covering query generation functions for Influx, ClickHouse and SiriDB databases. Tests are covering basic pre-generated outputs and provide visual sanity checks. More robust tests are left as a future task.

codecov-io commented 5 years ago

Codecov Report

Merging #76 into master will increase coverage by 7.58%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #76      +/-   ##
=========================================
+ Coverage   57.32%   64.9%   +7.58%     
=========================================
  Files          77      77              
  Lines        3810    3810              
=========================================
+ Hits         2184    2473     +289     
+ Misses       1595    1309     -286     
+ Partials       31      28       -3
Impacted Files Coverage Δ
...d/tsbs_generate_queries/databases/influx/devops.go 100% <0%> (+67.85%) :arrow_up:
...d/tsbs_generate_queries/databases/siridb/devops.go 100% <0%> (+72.41%) :arrow_up:
...bs_generate_queries/databases/clickhouse/devops.go 100% <0%> (+89.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a985875...c1bc78a. Read the comment docs.

antekresic commented 5 years ago

@RobAtticus updated the tests based on your feedback. Waiting with further changes until PR #77 is merged to master.

antekresic commented 5 years ago

@RobAtticus I rebased the PR with your latest changes and fixed them up to reflect them.

Could you take another look at it?

Thanks.