search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.29k stars 300 forks source link

Fix the way to set flags in scripts due to switching to viper lib #94

Closed hagen1778 closed 5 years ago

hagen1778 commented 5 years ago

Since flag parse lib was changed to viper - old way for passing flags in scripts doesn't work:

FORMATS=timescaledb ./scripts/generate_data.sh
Generating data_timescaledb_cpu-only_4000_2019-09-01T00:00:00Z_2019-09-03T00:00:00Z_10s_123.dat.gz:
unknown shorthand flag: 'f' in -format

This PR supposed to set the same way for passing flags for all scripts.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #94 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files         103      103           
  Lines        5720     5720           
=======================================
  Hits         3971     3971           
  Misses       1674     1674           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efa3e66...b8a4ea3. Read the comment docs.

bboule commented 5 years ago

@blagojts when you have a second could you take a look.

RobAtticus commented 5 years ago

Thanks for this, sorry for the delay!