search

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai
https://timeseriesai.github.io/tsai/
Apache License 2.0
5.1k stars 639 forks source link

add weight init method from RNNPlus to RNN #617

Closed yangtzech closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yangtzech commented 1 year ago

@oguiza is this PR OK? or should I close it?

oguiza commented 1 year ago

Hi @yangtzech , Apologies for the delay in reviewing this PR. I'm ok with the proposed changes. The init_weights option is available in the Plus versions of RNNs, but don't see any problem having it in the base versions. I'm getting an error message though showing you need to run nbdev_install_hooks before committing the changes. If you could do that and update the PR I'll be able to merge it.

yangtzech commented 1 year ago

Finally, I think I made it. Is it right that I just run nbdev_install_hooks in the command line? But it did not work. Then I tried nbdev_clean to remove information about execution counts, etc.

oguiza commented 1 year ago

I'm afraid it didn't work. The new branch to test the PR doesn't show up, so I cannot run it. I'd suggest you close this PR and create a new one using nbdev_install_hooks.

yangtzech commented 1 year ago

OK, I'll close. Still, Is it right that I just run nbdev_install_hooks in the command line? But it did not work.

oguiza commented 1 year ago

OK, I'll close. Still, Is it right that I just run nbdev_install_hooks in the command line? But it did not work.

Yes, that's the way you should use the nbdev_install_hooks. But once you run the command on the terminal, you should get a "Hooks are installed" message.

yangtzech commented 1 year ago

OK, I'll close. Still, Is it right that I just run nbdev_install_hooks in the command line? But it did not work.

Yes, that's the way you should use the nbdev_install_hooks. But once you run the command on the terminal, you should get a "Hooks are installed" message.

There indeed is a message. But it seems not to work.