add weight init method from RNNPlus to RNN

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai

https://timeseriesai.github.io/tsai/

Apache License 2.0

5.21k stars 651 forks source link

add weight init method from RNNPlus to RNN #640

Closed yangtzech closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yangtzech commented 1 year ago

Is this PR OK now? @oguiza

oguiza commented 1 year ago

Yes, it is @yangtzech. I've been able to merge this PR. You are now a tsai contributor!!

yangtzech commented 1 year ago

Thanks! It's my honor to be!