search

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai
https://timeseriesai.github.io/tsai/
Apache License 2.0
5.1k stars 639 forks source link

fix typo #649

Closed deven367 closed 1 year ago

deven367 commented 1 year ago

This PR fixes a minor typo in the 032_models.explainability notebook.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

deven367 commented 1 year ago

@oguiza Can you take a look at this?

oguiza commented 1 year ago

Sure! And sorry for the delay.

Since you are fixing a typo, it'd be good to change the "..if they rae not provided..." by "...if they are not provided..." in the same sentence you've updated.

oguiza commented 1 year ago

Hi @deven367, I'm getting an error that prevents me from merging your PR. It seems you'll need to use git pull and run nbdev_install_hooks before submitting the PR again.

deven367 commented 1 year ago

@oguiza I installed the hooks and ran nbdev_clean, I think this should fix the problem.

oguiza commented 1 year ago

Thanks @deven367 for creating this PR!