search

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai
https://timeseriesai.github.io/tsai/
Apache License 2.0
5.07k stars 633 forks source link

implement RNNAttention #668

Closed yangtzech closed 1 year ago

yangtzech commented 1 year ago

@oguiza , please take a look at this when you have time.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

oguiza commented 1 year ago

Hi @yangtzech , Thanks for creating this PR. I think it's a great addition to tsai. I have a few comments:

  1. There're a couple of other files that need to be modified to let the new models be constructed within the ts_learner, but I can take care of that once this PR is approved.
  2. I'm getting an error message with the PR: "Error: Notebooks and library are not in sync. Please run nbdev_export.". You should run 2 things before resubmitting the PR: nbdev_install_hooks and nbdev_prepare. Look forward to seeing the new model added to tsai.
yangtzech commented 1 year ago

I think I'll close this PR before messing up the repo.