search

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai
https://timeseriesai.github.io/tsai/
Apache License 2.0
5.07k stars 633 forks source link

implement RNNAttention #676

Closed yangtzech closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yangtzech commented 1 year ago

I did not edit 012_data.image.ipynb. Why is there an error?😰

oguiza commented 1 year ago

I did not edit 012_data.image.ipynb. Why is there an error?😰

I'm not sure where it's coming from (maybe GitHub's updated some libraries). I haven't updated it either. Anyway, I've fixed the issue now.

oguiza commented 1 year ago

Hi @yangtzech, I've just merged your RNNAttention PR, and have added the model to ts_learner, which means it should work as any other model in the library. Here's a gist I've created to quickly benchmark LSTM and LSTMAttention, and demonstrate how it can be used. Thank you so much for creating this PR!! And apologies for taking so long to merge it.

yangtzech commented 1 year ago

Thanks for your work!