TST parameter fixup - Githubissues

timeseriesAI / tsai

Time series Timeseries Deep Learning Machine Learning Python Pytorch fastai | State-of-the-art Deep Learning library for Time Series and Sequences in Pytorch / fastai

https://timeseriesai.github.io/tsai/

Apache License 2.0

4.91k stars 622 forks source link

TST parameter fixup #897

Open andersgb opened 2 months ago

andersgb commented 2 months ago

First commit should be trivially correct (docstring only) Second commit fixes a bug, which was my original intention for opening this PR Third commit reintroduces the original behavior because I don't think the assertion is necessary. I tried to understand and compare to how the pytorch implementation of multi head attention handles these dimensions.

So the net change of this PR is only docstring changes. See commit messages for further details.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.