Upgrade to the BeatFX section to have 3 effects with level meters and one for master FX level

[bvobart]

Hi there again Sven, @timewasternl :)

I've upgraded the BeatFX section to have space for the 3 FX units that can be controlled with a DDJ-400 using the default controller mapping. I found level meters to be particularly useful so I put them in too (the PNGs for those come from the Deere skin). And the skin preview has been updated too :)

On a side note, I've also done a bit of cleanup in the CSS and XMLs. I've now also set the version number to v0.5.0 because that's probably where it's at right now? :shrug: Might be nice to start keeping track of versions and tagging them / making releases.

Does this fix #1 ?

[timewasternl]

Marvellous work and nice theming. Although I understand the issues we still need to overcome, but I think there are some proposed changes in the DDJ-400 mapping in the Mixxx repo (for example https://github.com/mixxxdj/mixxx/pull/4662) that might stir the controller mapping up regarding the Beat FX. Maybe it's best to sit that one out before we will implement proper parameter control. I personally don't think shift+track select would be very intuitive. Also, it is out of scope for a skin as it would be mapping behaviour.

Nevertheless, thanks again for your great work. Merged!

[bencejuhaasz]

Nice work on the UI, I like it. However, this would introduce a technical limitation compared to my repo and mapping, because this way you are using three separate effects. A lot of specific FX's can be achieved by chaining those together, and I think this is what people are actually doing on industry standard setups, so I'll stick with my mapping, but I def. gonna merge the level meter sometimes, because a lot of fx chains create higher levels, which should be compensated live. Especially on my setup because I use additive fx mixing to have the option of a separate EQ on beatfx.

[bvobart]

Thanks for merging and thanks for the compliments :)

@timewasternl - I think there are some proposed changes in the DDJ-400 mapping in the Mixxx repo (for example https://github.com/mixxxdj/mixxx/pull/4662) that might stir the controller mapping up regarding the Beat FX

As far as I can see in that PR, it's about remapping the < > and V buttons to, respectively: previous effect, next effect, select effect from dropdown. As long as that doesn't actually change which of Mixxx' { rack, unit, effect } tuples the selectable effects map to, that should just work out of the box with this skin. I'm not aware of any other changes to the controller mapping, but we'll see.

For parameter control, we might be able to have a separate FX configuration section in a settings tab like I proposed in https://github.com/timewasternl/Pioneered/issues/11#issuecomment-1193025066 so we can configure effect parameters with the touchscreen, but we'll have to experiment with that and see what's possible. If we want it controllable through the DDJ-400 itself, then yeah that'll need to be fixed in the controller mapping. Tbh though, I don't really use effects enough to tinker with effects parameters.

@bencejuhaasz - A lot of specific FX's can be achieved by chaining those together

With the way the default DDJ-400 controller mapping is currently set up, the level/depth knob controls the master FX level and shift+level/depth controls the selected effect's level. The on/off button toggles the selected effect on and off. So that makes it possible to stack up to 3 effects by turning them on and setting their levels to what you want, then using the level/depth knob to mix them in all at once.