search

timewasternl / Pioneered

Pioneer inspired theme for smaller screen resolutions
GNU General Public License v3.0
51 stars 8 forks source link

Idea for 3 band EQ like on the newer C/X DJS #6

Open owenhaydenjoiner opened 2 years ago

owenhaydenjoiner commented 2 years ago

Yo man loving your skin for mixx im converting my ddj- t1 (from 2001) to a standalone. Ive been wokrking to make a version of Your skin that has the orange white and blue 3band waveforms that is an option of the newer X/C DJs. just wanted to hear your thougts on em. Ive got way more white than I want but got here in aout an hour so sure i can work it out. Pioneers: image

Mine: image

bencejuhaasz commented 2 years ago

This looks cool, can you share the code ?

bvobart commented 2 years ago

The waveform colours are not determined by the theme, but must be configured in Mixxx' settings: Options > Preferences > Waveforms > Waveform type. I don't see a 3-band setting there though, so I think you'll need to create a feature request issue with Mixxx for that.

Makes me wonder how you made that waveform in your preview picture though :)

timewasternl commented 2 years ago

Perhaps we can set different colour scheme's to match some of Pioneer's implementations in terms of Waveform colours.

bvobart commented 2 years ago

But is it possible to change the waveform colours outside of Mixxx' waveform settings? I don't think it's possible from within the skin.

bencejuhaasz commented 1 year ago

@owenhaydenjoiner Can you give some insight how you've set this up in mixxx ? Would be cool to have:)

bencejuhaasz commented 1 year ago

The closest I can get is setting the SignalLowColor, SignalMidColor, SignalHighColor keys and changing the waveform type to filtered.

timewasternl commented 1 year ago

The closest I can get is setting the SignalLowColor, SignalMidColor, SignalHighColor keys and changing the waveform type to filtered.

There are similar properties for the RGB ones. I'm currently not in the situation to test these, but they might be more fitting combined with the user's preferences

  <SignalRGBLowColor>#</SignalRGBLowColor>
  <SignalRGBMidColor>#</SignalRGBMidColor>
  <SignalRGBHighColor>#</SignalRGBHighColor>
bencejuhaasz commented 1 year ago

I just tested them, and they look very different from the pioneer one in RGB, because that doesn't separate the sound into 3 bands before generating the waveform, and ends up producing transitions in the colors, which is exactly the opposite of what this relatively new theme is about. However, without RGB it's close to fine. Only problem is that the high waveworm is displayed over the others, while pioneer has middle above all.

bencejuhaasz commented 1 year ago

This is the closest I can get: Screenshot_20230129_173426

timewasternl commented 1 year ago

This is the closest I can get: Screenshot_20230129_173426

Looks pretty decent. We might have this until we find a better solution. I'm not sure whether the Waveform Visual will be part of the skin engine overhaul or not.

owenhaydenjoiner commented 1 year ago

Hey man yeah for sure,

I'll dig it up tomorrow 👍

On Mon, 23 May 2022, 15:04 bencejuhaasz, @.***> wrote:

This looks cool, can you share the code ?

— Reply to this email directly, view it on GitHub https://github.com/timewasternl/Pioneered/issues/6#issuecomment-1134721867, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASNBQZVETI3PJ4MDE7SHQZDVLOF7VANCNFSM5QTNBBLA . You are receiving this because you authored the thread.Message ID: @.***>