timewave-computer / covenants

Apache License 2.0
17 stars 4 forks source link

Add party config updates to the two party POL #122

Open bekauz opened 10 months ago

bekauz commented 10 months ago

Both parties participating in the covenant should be able to update their part of the configuration. This may include the authorised claim address, connection / channel ids, etc.

uditvira commented 9 months ago

We need to confirm who can update what configurations. There are two types of configurations:

  1. Can be updated by a single party without the approval of the counterparty
  2. Needs approval of both parties

First, we need to delineate which configuration is of type 1 and which is of type 2.

Second, we need to decide how the type 2 configurations are updated. Within this, there are two possible directions we can take: a) We offload this feature to DAODAO where a 2 member DAO can update the contract where the voting policy for changes requires both parties to approve b) We develop a minimal 2-of-2 approval system within the covenant contracts

My personal preference, to keep our work scoped and reduce redundancy is to take direction a

uditvira commented 9 months ago

@bekauz can you take a first stab at this:

we need to delineate which configuration is of type 1 and which is of type 2

I'll be happy to review

bekauz commented 9 months ago

Sure. Params in question:

uditvira commented 5 months ago

We should prioritize adding methods for a single party to update their own configs where the second party's approval is not required.