covenant durations and deadlines

[bekauz]

Currently we treat covenant deadlines as expirations. For context, right now the two party POL covenant gets instantiated with a deposit deadline and a lockup deadline, both provided as timestamps/block heights in the future prior to covenant instantiation.

It may make sense to convert some of them into durations that only start counting from a specific point in the covenant flow, for instance:

• the deposit deadline could be set to 3 weeks and would start counting from the moment the covenant is instantiated
• the lockup deadline could be set to 1 year and would start counting from the moment holder receives both deposits

[Art3miX]

I think this can be easily done with introducing a wrapper enum:

enum Deadline {
  Expiration(cw_utils::Expiration)
  Duration { 
    start_at: BlockInfo, 
    duration: cw_utils::Duration
  }
}

and then a helper:

impl Deadline { 
  pub fn is_expired(&self, curr_block: &BlockInfo) {
    match self { ... }
  }
}

No even a bad idea to have it on the cw_utils, its a good UX.

[Art3miX]

Whats up with that?

We have the deadline helper in the utils, we just need to use it, 1 thing about it, is that in order to do this nicely, we add the serde(untagged) flag, this allows to "unwrap" the names, the issue with that is that it requires a specific wasmd version, which im not sure is supported on neutron (might be 1,4, or 1.5) cause it requires float support.