timewave-computer / valence-services

Other
3 stars 0 forks source link

Keep track of errors that happened on the rebalancer #16

Closed Art3miX closed 3 months ago

Art3miX commented 10 months ago

More details at: #5

Add a storage to keep track of failed message that happened for the rebalancer, in a perfect world, the rebalancer should not execute messages that are failing.

Status

Missing

Art3miX commented 10 months ago

Update - Nov 5th, 2023 (05/11/2023)

A custom event will be shown in the explorer if any error happened (it wont if none happened), this gives us some way of manually checking if an error happened during the rebalancer message and fix it.

The given errors are basic and will only show the error message and what type of an error (with account or with a message to the auction), but it won't give us more details (depending on the error). We do want to include more details, at least what address this error happened to, but reply is very limited, even more in case of an error, only available is the id and the error message, and id is u64 which limits what extra data we can pass to it.

We also want to automate the error showing to some off-chain list, so we won't relay on manually checking explorers.

Action

Art3miX commented 3 months ago

Closing. We address this directly in https://github.com/timewave-computer/server/pull/1, now in slack we will see if any account failed during rebalancing, and with our manual testing we can isolate the account config and see exactly what went wrong.