search

timewave-computer / valence-services

Other
3 stars 0 forks source link

Valence account have a "trustee" build in with permissions? #3

Closed Art3miX closed 2 months ago

Art3miX commented 11 months ago

Should we add a trustee on the account level? Sort of an admin of the account that can talk to for the account based on the permission the owner set for it?

Currently the rebalancer have a trustee that is allowed to pause or resume the rebalancer for an account. We can remove this trustee from the service level, and put it on the account level, where you can specify an address that act as a trustee (or admin) and do actions on the account.

We can add permissions, for example: FULL_CONTROL - trustee can do anything he wants on the account SERVICE_FULL_CONTROL - trustee can register / deregister / pause / resume / update any service he wants, but can't use the general message of an account (can't send money away) SERVICE_LIMITED_CONTROL - trustee can only pause or resume a service etc.

uditvira commented 11 months ago

I agree this should move to the account level. It may be better to have a trustee-service permissions mapping stored with the account though, because you may not want to grant the same trustee access to all your services at the same permission level.

stiiifff commented 2 months ago

Closing as not not relevant anymore.