timewave-computer / valence-services

Other
3 stars 0 forks source link

Possible issue with minimum amounts for auction #33

Closed Art3miX closed 4 months ago

Art3miX commented 5 months ago

Problem

We have 2 minimum amounts for the auction:

  1. Send minimum - how much funds each user can send to the auction
  2. Start minimum - how much the auction needs to have to start an auction

Those 2 serve different purposes, and currently those are the same, so its fine.

The issue starts when those 2 are different, especially in the start and for "exotic" pairs in the future We might reach into a point where the rebalancer says the account need to send K amount to an auction, but the auction need 2K to start, and no one else is sending funds to the auction, for a while.

This will lead to a case where we transfer the funds, but the auction transfers it back because not enough funds to start it. and this process will repeat indefinitely until the limit is met.

Action

Document this problem

stiiifff commented 5 months ago

Note: this happens when there's very low liquidity in the system.

uditvira commented 5 months ago

I think the only action here for now is to document this concern clearly. I updated the top level comment to make this clear

Art3miX commented 4 months ago

https://www.notion.so/Auctions-minimum-amounts-ca77d1bac99d43768c3b569c5f34705e

stiiifff commented 4 months ago

The issue was documented in Notion. Closing.