search

timewave-computer / valence-services

Other
3 stars 0 forks source link

Better testing #35

Closed Art3miX closed 6 months ago

Art3miX commented 7 months ago

We need better testing, discovered a bug that should have been tested but wasn't, no clue how it got over looked this far.

stiiifff commented 7 months ago

TODO: refine what we mean by better testing, be more specific.

Art3miX commented 7 months ago

I think it can be divided into 3 big topic, ordered by priority in my eyes:

  1. Export astroport test build to its own repo. this has several benefits, it will allow both covenant and rebalancer tests to use it, will remove all the astro specific code from the main repos which is very nice on its own, and also allow others to use it if they need it (or give a nice reference to astroport in creating their own thing)

  2. Add missing tests, we probably have several cases that are not testsed, one known missing test working with multiple denoms in different configurations.

  3. Organize code better, currently its not ideal, and we can make it nicer to make it easier to work with.

uditvira commented 6 months ago

The Astroport test work seems low priority for now, I'm afraid this is just going to sit in the backlog forever. Please correct me if @bekauz @Art3miX @stiiifff you feel otherwise. If you think it's important, then create a new specific issue for that.

Closing this issue in favour of a more actionable issue #43