timflannagan / rukpak

Rukpak runs in a Kubernetes cluster and defines an API for installing cloud native bundle content
Apache License 2.0
0 stars 0 forks source link

propagate invalid Bundle source type to status #11

Open github-actions[bot] opened 2 years ago

github-actions[bot] commented 2 years ago

return ctrl.Result{Requeue: false}, fmt.Errorf("failed to parse Bundle source type: %s is an unsupported Bundle type", bundle.Spec.Source.Type)

}

https://github.com/timflannagan/rukpak/blob/67cb1d88a8a15695d9b35ec07e2ea252d590afd1/internal/provisioner/plain/controllers/bundle_controller.go#L100


    }()
    u.UpdateStatus(updater.EnsureObservedGeneration(bundle.Generation))

    // switch bundle.Spec.Source.Type {
    // case "image":
    //  stub
    // case "git":
    //  stub
    // default:
    //  // TODO: propagate invalid Bundle source type to status
    //  return ctrl.Result{Requeue: false}, fmt.Errorf("failed to parse Bundle source type: %s is an unsupported Bundle type", bundle.Spec.Source.Type)
    // }

    pod := &corev1.Pod{}
    if op, err := r.ensureUnpackPod(ctx, bundle, pod); err != nil {
        u.UpdateStatus(updater.SetBundleInfo(nil), updater.EnsureBundleDigest(""))
github-actions[bot] commented 2 years ago

This issue has become stale because it has been open 60 days with no activity. The maintainers of this repo will remove this label during issue triage or it will be removed automatically after an update. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.