timflannagan / rukpak

Rukpak runs in a Kubernetes cluster and defines an API for installing cloud native bundle content
Apache License 2.0
0 stars 0 forks source link

what happens when len(objects) == 0? how to avoid silently storing zero manifest... #20

Open github-actions[bot] opened 2 years ago

github-actions[bot] commented 2 years ago

despite them being populated correctly in the Pod logs?

https://github.com/timflannagan/rukpak/blob/67cb1d88a8a15695d9b35ec07e2ea252d590afd1/internal/provisioner/plain/controllers/bundle_controller.go#L326


        return updateStatusUnpackFailing(u, fmt.Errorf("get bundle contents: %w", err))
    }

    // TODO: this doesn't apply to all bundle source types
    bundleImageDigest, err := r.getBundleImageDigest(pod)
    if err != nil {
        return updateStatusUnpackFailing(u, fmt.Errorf("get bundle image digest: %w", err))
    }
    // TODO: what happens when len(objects) == 0? how to avoid silently storing zero manifests
    // despite them being populated correctly in the Pod logs?
    objects, err := getObjects(bundleFS)
    if err != nil {
        return updateStatusUnpackFailing(u, fmt.Errorf("get objects from bundle manifests: %w", err))
github-actions[bot] commented 2 years ago

This issue has become stale because it has been open 60 days with no activity. The maintainers of this repo will remove this label during issue triage or it will be removed automatically after an update. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.