search

timfraedrich / OutRun

OutRun is an open-source, privacy oriented, outdoor fitness tracker.
https://outrun.tadris.de
GNU General Public License v3.0
697 stars 64 forks source link

Potentially incorrect prompt label when deleting workout #60

Open natanlao opened 3 years ago

natanlao commented 3 years ago

Describe the bug When deleting a workout, Outrun prompts asking whether or not to remove the workout from Apple Health. One of the dialog buttons says "NIL", which I assume should be "Cancel" or something like that.

To Reproduce Steps to reproduce the behavior:

  1. Create and save a workout.
  2. Scroll to the bottom and tap "Delete"
  3. Tap the first "Delete" button in the "Delete Workout?" prompt
  4. The next prompt will list two choices: "NIL" and "Delete"

Expected behavior Button label is not "NIL"

Screenshots photo1619415974

Device Information (please complete the following information):

Additional context None

timfraedrich commented 3 years ago

Thanks for pointing that out, apparently somehow some strings in the translation files have been deleted which led to some not being available in a few languages, that's why it just says "NIL", the missing string is actually "Keep", I already re-added it and will investigate if anything else is missing.

natanlao commented 3 years ago

Ok, thanks -- in that case, I'll defer closing this issue to you.

I like the app a lot, by the way, thanks for your work on it!