search

timgit / pg-boss

Queueing jobs in Postgres from Node.js like a boss
MIT License
2.09k stars 158 forks source link

Highlight unknown Resolute namespace #294

Closed bwalding closed 2 years ago

bwalding commented 2 years ago

I updated to pg-boss 7 and got an error during compilation about an unknown namespace Resolute - was this a typo? IIUC it should be PgBoss - anyway - feel free to close this PR - I raised it in the event my change was correct.

Also - looking in publishTest.js - it looks like there should be additional method signatures for publish (similar to send). I did not address that - in the event I was on the wrong track.

$ tsc --noEmit types.d.ts
types.d.ts:307:20 - error TS2503: Cannot find namespace 'Resolute'.

307   publish(request: Resolute.Request): Promise<string[]>;
                       ~~~~~~~~

Found 1 error.
coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f2476f53b6f8d83cb86f94bbe83c80d5b0a4787e on bwalding:master into 8d34ab7426fb8c45e82df2b08cda7756ee63e4ea on timgit:master.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f2476f53b6f8d83cb86f94bbe83c80d5b0a4787e on bwalding:master into 8d34ab7426fb8c45e82df2b08cda7756ee63e4ea on timgit:master.

timgit commented 2 years ago

Thanks!