search

timgit / pg-boss

Queueing jobs in Postgres from Node.js like a boss
MIT License
2.05k stars 157 forks source link

Bug: JobDoneCallback type should have optional parameters #65

Closed robgraeber closed 6 years ago

robgraeber commented 6 years ago

https://github.com/timgit/pg-boss/blob/master/types.d.ts#L74

The done() callback's parameters should be typed as optional, typescript users right now have to do: job.done(null, null)

timgit commented 6 years ago

PRs are encouraged for typescript. Pretty much everything you see here are from my dedicated typescript PR team. 😁

typescriptandme

robgraeber commented 6 years ago

@timgit you got it: https://github.com/timgit/pg-boss/pull/66

robgraeber commented 6 years ago

Closed in https://github.com/timgit/pg-boss/pull/66