Cast datetimes and add 'not between' operator

timgws / QueryBuilderParser

A simple to use query builder for the jQuery QueryBuilder plugin for use with Laravel.

MIT License

159 stars 65 forks source link

Cast datetimes and add 'not between' operator #22

Closed timgws closed 6 years ago

timgws commented 6 years ago

I accidentally merged #21.

This work was mainly done by @sgjackman @wpanec-uno. Thanks for the contribution peeps!

Please note my comment about dates, this change still needs testing! https://github.com/timgws/QueryBuilderParser/pull/21#issuecomment-340354857

coveralls commented 6 years ago

Coverage decreased (-2.7%) to 97.268% when pulling 6e9b395114407864a5f3b6fd1cce382b8a6bdbaa on elasticquent:master into 254486179ba8806e068f030715d67778f034e5e9 on timgws:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling e529769ba828306d06c41eef9e574d8a1bcf2776 on elasticquent:master into 254486179ba8806e068f030715d67778f034e5e9 on timgws:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling e529769ba828306d06c41eef9e574d8a1bcf2776 on elasticquent:master into 254486179ba8806e068f030715d67778f034e5e9 on timgws:master.

wpanec-uno commented 6 years ago

Hey @timgws, sorry I got tasked to work on a different feature for a while. I'll try everything out against MySQL either today or tomorrow. Are there any additional unit tests that need to be created?

timgws commented 6 years ago

@wpanec-uno I think it's pretty much all here now. There is 100% coverage, and everything seems to work fine :-)

FBnil commented 6 years ago

@timgws For Laravel users that want to help testing.

README.md is missing the usual composer require timgws/query-builder-parser but this will pull version 1.4 (new tag needed?)

To get the latest, go into composer.json and replace ^1.4 withdev-master then composer update yourself to the latest version.

wpanec-uno commented 6 years ago

@timgws OK, sounds good!