search

timhagn / gatsby-background-image

Lazy-loading React (multi)background-image component with optional support for the blur-up effect.
MIT License
253 stars 49 forks source link

fix: Set correct gatsby peer deps #153

Closed LekoArts closed 3 years ago

LekoArts commented 3 years ago

Hello @timhagn, Gatsby maintainer here πŸ‘‹ First and foremost, thanks for creating the plugin & maintaining it. Much appreciated!

While looking at your plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #153 (fd42cea) into main (ee02076) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          865       865           
  Branches       370       370           
=========================================
  Hits           865       865

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ee02076...fd42cea. Read the comment docs.