timhagn / gatsby-background-image

Lazy-loading React (multi)background-image component with optional support for the blur-up effect.
MIT License
253 stars 49 forks source link

Provide compatibility with Gatsby v4 #168

Closed Vacilando closed 2 years ago

Vacilando commented 2 years ago

This plugin currently does not install under Gatsby v4.

npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^2.0.0 || ^3.0.0" from gatsby-background-image@1.5.3
npm ERR! node_modules/gatsby-background-image
npm ERR!   gatsby-background-image@"^1.*" from the root project
github-actions[bot] commented 2 years ago

Hi there! As @timhagn momentarily is the main contributor to this package, this issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs, though we're open to suggestions on how to get more maintainers! Thank you for your contributions : )!

Vacilando commented 2 years ago

Can we please reopen this. This ticket is clearly necessary for the future of this plugin, there are 8 users who've indicated they support the idea, and I'm sure there are more.

While it's understandable that Tim cannot do everything right away, it does not mean tickets should be just closed.

timhagn commented 2 years ago

Hi there,

am currently flooded with work and to be honest mostly working with next.js. Probably have set the GH action a little too eager to close issues... Will try to add || ^4.0 next week to package.json.

Best,

Tim.

timhagn commented 2 years ago

Hi there,

as @garbledTech provided a PR for it I merged in both open ones & just published gbi(-es5)@v1.6.0 & gbimage-bridge@0.2.0.

Please let me know if it now works with Gatsby 4 : ).

Best,

Tim.

EDIT: Typo & Formatting

Vacilando commented 2 years ago

Installs and works flawlessly with Gatsby v4 now. Thanks!