timhaley94 / holdem

Real time poker in JavaScript
https://holdemhounds.com
GNU General Public License v3.0
7 stars 7 forks source link

Dockerize lint, test, and other scripts #106

Closed timhaley94 closed 4 years ago

timhaley94 commented 4 years ago

Background

Right now to stand up the environment for local development, you run docker-compose up. However, to run tests or to lint, you have to install dependencies outside of docker and run the command yourself. Not only is this weird, but it also will not be tenable when the tests rely on mongo since running the test suite outside of docker would require you standing up mongo locally on your own.

Current Behavior

What it does: Lint and test occur outside of docker.

Proposed Behavior

What it should do: A new directory should be introduced, probably called .bin, which provides shell scripts that do things like linting and testing inside the docker container. For this feature, we could start with just up.sh, down.sh, lint.sh, test.sh, build.sh.

Open Questions

Can we make up.sh reinstall dependencies. If not, we should figure out how to do that or include a install.sh script.