search

timhaley94 / holdem

Real time poker in JavaScript
https://holdemhounds.com
GNU General Public License v3.0
7 stars 7 forks source link

Introduce scripts.sh file #107

Closed timhaley94 closed 4 years ago

timhaley94 commented 4 years ago

Fixes #106

Background

Right now commands like lint and test do not have access to all the containers created by docker compose. Right now this doesn't matter, the only thing that server depends on is redis, however we are mocking redis. Once we introduce mongo though, we will want our scripts to actually have access to redis and mongo so that they can be true integration tests. You can achieve this using docker-compose exec although this is a lot for new developers to remember and is a lot to type. This PR introduces a scripts.sh which encapsulates these calls to docker-compose exec.

Proposed Changes

Technical changes: Introduces a scripts.sh which encapsulates all commands that will need to be run against the docker compose cluster.

Future work

What will we need to do later: Have CI use this file instead of calling the npm scripts directly.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 6c1b9f98 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 26.0% (0.0% change).

View more on Code Climate.