timhaley94 / holdem

Real time poker in JavaScript
https://holdemhounds.com
GNU General Public License v3.0
7 stars 7 forks source link

Have CI/CD use scripts.sh #108

Closed timhaley94 closed 4 years ago

timhaley94 commented 4 years ago

Background

When introduced scripts.sh, however we need CI/CD to use it. Not only is it good to keep things consistent between development and CI, but it will also be a hard requirement when we have tests which use mongodb.

Current Behavior

What it does: CI/CD directly calls npm scripts outside of docker environment.

Proposed Behavior

What it should do: Calls all scripts through ./scripts.sh file thus executing them inside the docker environment.

Open Questions

May need to introduce another subcommand to scripts.sh for building the client.