timhaley94 / holdem

Real time poker in JavaScript
https://holdemhounds.com
GNU General Public License v3.0
7 stars 7 forks source link

Fix up some things with docker to hopefully resolve prod issues #92

Closed timhaley94 closed 4 years ago

timhaley94 commented 4 years ago

Background

The server isn't running correctly in prod. Current theory is that because the start script for server was using pm2, which starts a background process, the container immediately dies. At least this is what happened when I pulled the latest server image locally. Additionally, we don't need pm2 because there are beanstalk settings that will restart containers when the die.

Proposed Changes

Technical changes:

Future work

What will we need to do later:

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit b751d20c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 25.4% (0.0% change).

View more on Code Climate.