search

timhall / svelte-apollo

Svelte integration for Apollo GraphQL
MIT License
944 stars 68 forks source link

chore: update types to account for changes in TypeScript 4.8 #128

Closed alessbell closed 8 months ago

alessbell commented 1 year ago

In @apollo/client v3.7.6, we made a TS upgrade that prompted us to propagate constraints on generic types:

Technically this makes some types stricter as attempting to pass null|undefined into certain functions is now disallowed by TypeScript, but these were never expected runtime values in the first place.

I was taking a look at how the stricter types impacted community projects and thought I'd open this PR. The TVariables generics are stricter, but this should hopefully not result in breaking changes for users since it more accurately reflects the types we expect at runtime.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3215b79ba02b3ac371e2fc60436b2ad792583e05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------------------- | ----- | | svelte-apollo | Patch | | @svelte-apollo/example-svelte | Patch | | @svelte-apollo/example-sveltekit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alessbell commented 8 months ago

If there's any interest in reviving this PR, feel free to ping me :) Closing for now.