search

timheuer / alexa-skills-dotnet

An Amazon Alexa Skills SDK for .NET
MIT License
547 stars 108 forks source link

Made TellWithAskForPermissionsConsentCard method name consistent #247

Closed ncipollina closed 2 years ago

ncipollina commented 2 years ago

I noticed that the overloads for TellWithAskForPermissionsConsentCard were missing the s in the word Permissions. I marked the two methods that were named incorrectly as Obsolete so that it wouldn't break for anyone currently using them and added overloads with the same spelling.

timheuer commented 2 years ago

Watchful eye @ncipollina! I'd have no objections really I'm curious that this may affect others as a 'breaking' change due to a warning is now emitted and some folks with WarningsAsErrors would see this as a breaking change.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.