search

timheuer / callisto

A control toolkit for Windows 8 XAML applications. Contains some UI controls to make it easier to create Windows UI style apps for the Windows Store in accordance with Windows UI guidelines.
http://timheuer.com/blog/archive/2012/05/31/introducing-callisto-a-xaml-toolkit-for-metro-apps.aspx
Other
338 stars 108 forks source link

CustomDialog MaxWidth ? #122

Closed Kuirak closed 11 years ago

Kuirak commented 11 years ago

I am currently working with your custom dialog control and want to add a gridview to it. I discovered that you set a MaxWidth="680" which causes ugly clipping of the gridview content and the scrollbar.

Why did you introduce this value? Doesn't the automatic width handle that everything is working with different resolutions?

Is there a way to overwrite the customdialog style to get rid of the maxwidth or is it really needed?

Greets Kuirak

timheuer commented 11 years ago

This width is per the UI guidelines for windows. Perhaps the correct fix here is actually padding to anticipate the scroll area.

-th

Sent from mobile - please excuse tone and brevity

On Nov 20, 2012, at 7:09 AM, Kuirak notifications@github.com wrote:

I am currently working with your custom dialog control and want to add a gridview to it. I discovered that you set a MaxWidth="680" which causes ugly clipping of the gridview content and the scrollbar.

Why did you introduce this value? Doesn't the automatic width handle that everything is working with different resolutions?

Is there a way to overwrite the customdialog style to get rid of the maxwidth or is it really needed?

Greets Kuirak

— Reply to this email directly or view it on GitHub.

Kuirak commented 11 years ago

Hi tim, I did some testing and can't get the padding to work with the Current set up of UIelements. I also tried different values for maxwidth and realized around 900 is a good value if you want to have some bigger content like a gridview with tiles in the dialog. It still working on surface sized screen, even in 2/3 mode. During testing I discovered that snapped view isnt working correct even the backbutton isn't displayed any more (the title string has around 25 chars).

We need to find a better way to handle different width or a way to manipulate the source style theme.

regards

timheuer commented 11 years ago

In order to keep compatibility with the guidelines in the hope that some future platform control might be provided I'm not going to alter the max width. It is the same used in other dialogs throughout the system.