search

timheuer / callisto

A control toolkit for Windows 8 XAML applications. Contains some UI controls to make it easier to create Windows UI style apps for the Windows Store in accordance with Windows UI guidelines.
http://timheuer.com/blog/archive/2012/05/31/introducing-callisto-a-xaml-toolkit-for-metro-apps.aspx
Other
338 stars 108 forks source link

Why to make Flyout as IDisposable? #130

Closed xperiandri closed 11 years ago

xperiandri commented 11 years ago

Flyout does not use any direct unmanaged resource, so why to implement it as IDisposable?

And how do you imagine its usage as IDisposable?

timheuer commented 11 years ago

Because this current implementation uses a visual element not within the app's visual tree it is possible to have a leak. I added this for GC cleanup when the flyout is closed.

http://timheuer.com/blog/ twitter: @timheuer

On Tue, Nov 27, 2012 at 8:28 AM, xperiandri notifications@github.comwrote:

Flyout does not use any direct unmanaged resource, so why to implement it as IDisposable?

And how do you imagine its usage as IDisposable?

— Reply to this email directly or view it on GitHubhttps://github.com/timheuer/callisto/issues/130.

tibel commented 11 years ago

Shouldn't it be the same with SettingsFlyout?