CustomDialog should dismiss on ESC

[GIORGIOSF]

CustomDialog is supposed to enhance Windows' MessageDialog, however - if I understand well - it lacks some fundamental features:

• MessageDialog is invoked with await ... ShowAsync, that makes it modal;
• by means of the CommandinvokedHandler, MessageDialog can easily inform the calling program of what button was clicked by the user;
• 'Esc' dismisses MessageDialog with a default response, whereas CustomDialog ignores it.

Is there any way to address these limitations? To implement an "Enter password" dialog, I need the capability of CustomDialog to add fields, such as PasswordBox in this case, but at the same time (a) I need it to be modal; and (b) to easily report the entered password.

[timheuer]

@GIORGIOSF Thanks for the log. A few comments.

• MessageDialog is actually not modal, but rather UI modal still. CustomDialog here is technically the same however as you point out doesn't use a "Show" pattern.
• The MessageDialog is implemented in a different framework (not XAML) and follows a different event pattern. I believe that most developers would be okay with the current method of CustomDialog however I note your feedback, but wouldn't change the event model at this point.
• ESC dismissing -- the back button can handle the dismissal and is more explicit. I would consider adding ESC but don't think that it is mandatory for this functionality. Since this is the only one I'd concsier changing I'm going to edit the title of this bug to reflect that.

[GIORGIOSF]

Thank you for your comments and clarifications.

Sent from Windows Mail

From: Tim Heuer Sent: ‎June‎ ‎4‎, ‎2013 ‎4‎:‎17‎ ‎AM To: timheuer/callisto CC: GIORGIOSF Subject: Re: [callisto] CUSTOM DIALOG (#207)

@GIORGIOSF Thanks for the log. A few comments. MessageDialog is actually not modal, but rather UI modal still. CustomDialog here is technically the same however as you point out doesn't use a "Show" pattern. The MessageDialog is implemented in a different framework (not XAML) and follows a different event pattern. I believe that most developers would be okay with the current method of CustomDialog however I note your feedback, but wouldn't change the event model at this point. ESC dismissing -- the back button can handle the dismissal and is more explicit. I would consider adding ESC but don't think that it is mandatory for this functionality. Since this is the only one I'd concsier changing I'm going to edit the title of this bug to reflect that.

— Reply to this email directly or view it on GitHub.