If no image icon in settingsflyout is provided, make sure it doesn't take up space

[dotMorten]

if no image icon in settingsflyout is provided, make sure it doesn't take up space but leave the room for the HeaderText

[timheuer]

Interestingly enough, image icon is required per UX guidelines. In fact if there was an API to get it from the package, I would have just done that.

Given the UX guidelines I'm inclined to reject this.

---

http://timheuer.com/blog/ twitter: @timheuer

On Fri, May 18, 2012 at 3:51 PM, Morten Nielsen < reply@reply.github.com

wrote:

if no image icon in settingsflyout is provided, make sure it doesn't take up space but leave the room for the HeaderText

You can merge this Pull Request by running:

git pull https://github.com/dotMorten/callisto dev

Or you can view, comment on it, or merge it online at:

https://github.com/timheuer/callisto/pull/32

-- Commit Summary --

• If no image icon in settingsflyout is provided, make sure it doesn't take up space and leave room for the HeaderText

-- File Changes --

M src/Callisto/themes/Generic.xaml (2)

-- Patch Links --

https://github.com/timheuer/callisto/pull/32.patch https://github.com/timheuer/callisto/pull/32.diff

---

Reply to this email directly or view it on GitHub: https://github.com/timheuer/callisto/pull/32

[timheuer]

Deciding not to take this given WinJS settings pane design