search

timheuer / callisto

A control toolkit for Windows 8 XAML applications. Contains some UI controls to make it easier to create Windows UI style apps for the Windows Store in accordance with Windows UI guidelines.
http://timheuer.com/blog/archive/2012/05/31/introducing-callisto-a-xaml-toolkit-for-metro-apps.aspx
Other
338 stars 108 forks source link

Minor Flyout and SettingsFlyout changes #38

Closed lambda125 closed 12 years ago

lambda125 commented 12 years ago
  1. Fixed dependency property to refer to the Flyout (was typeof(Menu) before)
  2. Modified PopInThemeAnimation in SettingsFlyout to be a bit more obvious (perhaps this could be further improved by parameterising it and let the calling code specify/override this property?
timheuer commented 12 years ago

Thanks Krishna

I have the dp fixes in queue as well as I noticed those myself. The offsets on the flyout itself are per the design specs from windows so I won't take those changes.

-th

Sent from mobile - please excuse tone and brevity

On Jun 1, 2012, at 7:24 AM, Krishna Nadimintireply@reply.github.com wrote:

  1. Fixed dependency property to refer to the Flyout (was typeof(Menu) before)
  2. Modified PopInThemeAnimation in SettingsFlyout to be a bit more obvious (perhaps this could be further improved by parameterising it and let the calling code specify/override this property?

You can merge this Pull Request by running:

git pull https://github.com/krishna-nadiminti/callisto master

Or you can view, comment on it, or merge it online at:

https://github.com/timheuer/callisto/pull/38

-- Commit Summary --

-- File Changes --

M src/Callisto/Controls/Flyout/Flyout.cs (24) M src/Callisto/Controls/Settings/SettingsFlyout.cs (2)

-- Patch Links --

https://github.com/timheuer/callisto/pull/38.patch https://github.com/timheuer/callisto/pull/38.diff

Reply to this email directly or view it on GitHub: https://github.com/timheuer/callisto/pull/38

lambda125 commented 12 years ago

Cool - re:dp fixes.

Regarding the offsets on the flyout - would it be worth exposing that as a dep property itself - so that callers can optionally override the default offset of 10: In my case I just don't find the default obvious enough - so I tried using an offset of 40 which looked better to me.

timheuer commented 12 years ago

I'm trying to stay true to form with the UI guidelines on the animations. The design is to be subtle and not jarring/obvious actually. You'll see this in the system flyouts how subtle it is.