search

timheuer / callisto

A control toolkit for Windows 8 XAML applications. Contains some UI controls to make it easier to create Windows UI style apps for the Windows Store in accordance with Windows UI guidelines.
http://timheuer.com/blog/archive/2012/05/31/introducing-callisto-a-xaml-toolkit-for-metro-apps.aspx
Other
338 stars 108 forks source link

OAuthTools.GetSignature method throws NotImplementedException #44

Closed chrischiaro closed 12 years ago

chrischiaro commented 12 years ago

In OAuthTools.cs, line 310 (inside the final GetSignature overload) throws a NotImplementedException because it passes “HMAC_SHA1” into the OpenAlgorithm method. According to the documentation on MSDN "HMAC_SHA1" isn’t a valid value.

Since the algorithm provider class instantiated inside the method is only used to specify which provider implementation should be used in your HashWith extension method (Extensions.cs, line 414), perhaps a better implementation would be to just translate the OAuthSignatureMethod enum value into a string and pass that into the HashWith method. As long as the “HMAC_SHA1” string gets passed into the MacAlgorithmProvider.OpenAlgorithm method, things work fine.

timheuer commented 12 years ago

Fixed in latest code and 1.0.6 release