search

timheuer / callisto

A control toolkit for Windows 8 XAML applications. Contains some UI controls to make it easier to create Windows UI style apps for the Windows Store in accordance with Windows UI guidelines.
http://timheuer.com/blog/archive/2012/05/31/introducing-callisto-a-xaml-toolkit-for-metro-apps.aspx
Other
338 stars 108 forks source link

Flyout closing doesn't update IsOpen #79

Closed stefanolson closed 12 years ago

stefanolson commented 12 years ago

When the flyout gets closed by clicking outside of it, IsOpen is not set to false. I would suggest this change: In Flyout.OnHostPopupClosed

IsOpen = false;

timheuer commented 12 years ago

The object is gone at this point though...is this causing an issue for you? if so, what's the use case here? I'm not disagreeing that the value isn't being set, but it shouldn't have an impact as the dismissal of the flyout removes the object.

stefanolson commented 12 years ago

What I'm doing at the moment, in order to be maximise the code sharing with WPF and windows phone, where I'm using a context menu, is not recreating the fly out every time it is needed. So, when they click requiring the menu to appear I set IsOpen to true. Unfortunately if it hasn't been set to false then setting it to true does nothing.