Net standard1.4 - Githubissues

timheuer / taglib-sharp-portable

.NET Portable Class Library implementation of TagLib# (forked from TagLib# main project)

Other

58 stars 33 forks source link

Net standard1.4 #21

Closed Davidblkx closed 2 years ago

Davidblkx commented 7 years ago

Added support to NetStandard 1.4, so it could be used in NetCore and ASP.Net Core Projects
Copy tests from Portable class to NetStandard one
Fix Dispose() method from File.cs and tests so save tags to file
Fix some cast errors preventing tests from work

There are still an error at get some tags from jpg files

LukePulverenti commented 7 years ago

@Davidblkx any interest adding your fork to nuget, and/or incorporating newer upstream commits? https://github.com/mono/taglib-sharp/commits/master

Davidblkx commented 7 years ago

@LukePulverenti I don't have the time to incorporating newer upstream. Regarding Nuget I've uploaded my fork at https://www.nuget.org/packages/Taglib-Sharp-NetStandard/

Sohra commented 7 years ago

Is anything blocking this from being accepted? David's NuGet package isn't strongly signed, and probably isn't going to be updated(?). It'd be great if his work could be released in a new version of TagLib.Portable.