search

timholy / AffineTransforms.jl

Computational geometry with affine transformations
Other
20 stars 6 forks source link

Case where the matrix and the translation do not have the same eltype. #19

Closed mdavezac closed 7 years ago

mdavezac commented 7 years ago

The main case of interest are vectorial spaces with units, say via Unitful. Then the translations in the affine transforms also have units, but the matrices are unitless.

This pull-request "works", as evidenced by a test. But the API is probably not satisfactory. Any recommendations/ideas on how to go about this?

mdavezac commented 7 years ago

Thanks for pointing me to CoordinationTransformations. I can see why you are planning on switching. I just might do the same :)

In any case, your changes do indeed get rid of the ugliness in the constructor.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling b3a4c48d79c2b7f45cea4d212ad6bca918a7bf47 on mdavezac:unitful into f117b54dfcbce6d3c13509e9d23299ba35cf4540 on timholy:master.

timholy commented 7 years ago

Merged, see https://github.com/timholy/AffineTransforms.jl/commits/master.

I squashed into two commits, one for the test sets and the other for the "core" change. Thanks for keeping your commits so nicely separated, and of course for the excellent enhancement to the package!