Closed kimikage closed 4 years ago
Merging #30 into master will increase coverage by
0.02%
. The diff coverage is87.50%
.
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 96.53% 96.56% +0.02%
==========================================
Files 5 5
Lines 231 233 +2
==========================================
+ Hits 223 225 +2
Misses 8 8
Impacted Files | Coverage Δ | |
---|---|---|
src/graph.jl | 97.61% <80.00%> (+0.02%) |
:arrow_up: |
src/io.jl | 98.03% <100.00%> (+0.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fb240cd...2adf606. Read the comment docs.
If https://github.com/JuliaLang/julia/issues/35870 is fixed,, the tests on x86 may show the warning. However, I haven't been able to identify the reason why so many instruction pointers stored on 32-bit system.
Thanks @kimikage!
This fixes #28.
~This also fixes the potential stack overflow of
status()
. However,flamegraph!()
can still cause a stack overflow. So, we can also remove the change from this PR.~Profiling on 32-bit systems seems to be "somewhat" different than on 64-bit systems.